See the patch

CommentFileSizeAuthor
#13 drupal-482920-follow-up.patch976 bytestobiasb
#11 482920-11.patch1.32 KBJamesAn
#9 482920-9.patch1.32 KBJamesAn
#7 482920-7.patch2.61 KBJamesAn
#2 drupal-node_access_rebuild-482920-2.patch2.14 KBtobiasb
drupal-node_access_rebuild.patch580 bytestobiasb

Comments

dries’s picture

dries commented

Welp. Should we write a test for this?

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
StatusFileSize
new drupal-node_access_rebuild-482920-2.patch2.14 KB

ok, now with a small test.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks1

dries’s picture

dries commented
Status: Fixed » Needs review

I had to roll this patch back. Broke my environment. Need to investigate.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

There also needs to be a t() around 'Rebuild permissions' in l('Rebuild permissions', 'admin/reports/status/rebuild').

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review

Wierd. The commit logs show a change to a description line that was not included in the patch:
http://cvs.drupal.org/viewvc.py/drupal/drupal/modules/node/node.module?r...

JamesAn’s picture

JamesAn commented
Priority: Normal » Critical
StatusFileSize
new 482920-7.patch2.61 KB

Inserted the t().

We need this committed asap as all the patches are failing at the "Node Access Rebuild" test.

Status: Needs review » Needs work

The last submitted patch failed testing.

JamesAn’s picture

JamesAn commented
Status: Needs work » Needs review
StatusFileSize
new 482920-9.patch1.32 KB

Oops. Didn't realize that node.test wasn't rolled back along with node.module. This should work.

Status: Needs review » Needs work

The last submitted patch failed testing.

JamesAn’s picture

JamesAn commented
Status: Needs work » Needs review
StatusFileSize
new 482920-11.patch1.32 KB

Silly strings. The reversion wasn't exact, in that it changed the description line:
'Rebuild permissions' to 'Rebuild Permissions', which broke the rebuild permissions test as the link clicks are case sensitive.

This patch should fix it all. Phew.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Fixed

Thanks. Committed this too. Tentatively switching testing bot back on...

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
StatusFileSize
new drupal-482920-follow-up.patch976 bytes

getInfo() must be static in E_STRICT Modus.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Fixed » Needs review
dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

Sorry for messing up -- I 'corrected' those link titles manually.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.