I find this .sh extension confusing, since you expect it's a shell script.
You could also keep the .sh file, but make it a shell wrapper script to the php file.

Comments

boombatower’s picture

boombatower commented
Title: [run-tests.sh] why not renaming it to "run-tests.php" ? » Rename run-tests.php to run-tests.sh
Project: SimpleTest » Drupal core
Version: 6.x-2.x-dev » 7.x-dev
Component: Miscellaneous » simpletest.module
Priority: Minor » Normal

Totally agree. It used to be runnable as a shell script, but it was changed to attempt to auto detect php interpreter location and actually makes it more annoying since it doesn't work on more machines then it does (including mine). I would prefer we go back to assuming /usr/bin/php and allow those that it isn't to manually change it.

Either that or we rename the file to .php, but this needs to be done in core and backported.

boombatower’s picture

boombatower commented
Title: Rename run-tests.php to run-tests.sh » Rename run-tests.sh to run-tests.php

doh

this needs to be updated on test bot when/if changed.

damien tournoud’s picture

damien tournoud commented
Status: Active » Closed (won't fix)

No. The .sh extension is there so that the webserver will never try to execute the file itself.

RockyRoad’s picture

RockyRoad commented

That sounds a bit weird.
Isn't it the role of apache to take care of that sort of things, if critical ?
I'd look towards .htaccess solutions

My two cents.