It's confusing that when you click on someone's name on a blog entry as "Bob smith" you end up at a page with a title of "stinky2023". We should use the same display output here as well.
This is split off from #229660: Use theme_username() in the personal contact form where this originally came up.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | theme-username-D6.patch | 1.69 KB | andypost |
| #5 | theme-username.patch | 1.69 KB | andypost |
| #2 | theme-username.patch | 1.37 KB | andypost |
Comments
Comment #1
webchickAlso, this *should* be a novice issue, in that it is probably be a one or two line fix, although it might be a bit of an adventure figuring out where this title is set.
Comment #2
andypostSo here the patch both for
so testing
Comment #3
dixon_I suggest that we fix the issue I created over @ #465160: Make theme_username() able to return username without link first. Before we fix this. I think it is a little bit "hacky" to use
filter_xss()where we don't want the username linked.This solution was first suggested by pwolanin over @ #229660: Use theme_username() in the personal contact form
Comment #4
webchickThat sounds good to me!
Comment #5
andypostHere the new patch that also fixes user_view
Is it possible to backport this to 6.x? patch incl
Comment #6
plan9 commentedHow about a 5.x patch?
Comment #7
Dave Cohen commented#192056: User's raw login name should not be output directly attempts to solve this problem, too.
Comment #8
andypostSuppose it's time to review this
Comment #10
rschwab commentedIn todays 7.x-dev package, within user.module:
I believe this was probably fixed in the post Dave Cohen mentions in #7. I looked briefly at user.module and format_username() is in wide usage.
Comment #11
rschwab commentedMore accurate status.