Support custom role name in drupalCreateUser()

The value you set the select to is the key used in the options array?

Also try adding the following after the $this->drupalPost() call and posting the result.

file_put_contents('output.html', $this->drupalGetContent());

This is something that should be decided and committed to Drupal 7 core SimpleTest and then backported.

I have created a patch, but it does not contain a test. I would like to get some more opinions on this.

Obviously we have a usecase and would seem like something that the test should be able to control if it needs to.

Heh, defeats the point. Nice catch.

/me reminds self to check simple patches.

+1. Looks like a clean and simple improvement to me.

Comments should be full sentences, maybe something like:

+   *   The name of the role to create. If not set, a random name will be used.

instead of:

+   *   Name of role to create. If NULL then will use randomName().

This seems to be a bit of a hack. What if I want to assign multiple roles? What if I want to have control over what permissions are associated with what role.

It almost sounds like we want to be able to pass in:

  array(
    'my role 1' => array('permission 1', 'permission 2'),
    'my role 2' => array('permission 1', 'permission 3'),
  );

instead of:

  array('permission 1', 'permission 2')

I don't know. I'd like to see us discuss the API a bit more.

I briefly pondered whether drupalCreateUser could be rewritten like:

drupalCreateUser(
  array(
    'username' => 'alpha',
    'mail' => 'alhpa@example.com',
    'role' =>
      array(
        'role_a' => array('access content');
      )
  )
);

The reasoning was that some of the currently existing tests bypass drupalCreateUser because they need to set specific properties when creating a user.

In the end it looked like overkill though, since 99% of the tests don't seem to need it, and the others just create users themselves (bypassing drupalCreateUser)

We should improve the core role and permission API is what we should do. #300993: User roles and permissions API We want to remove the special stuff from drupalCreateRole and drupalCreateUser().