I have dug through the path that the code follows, and it comes down to the place in drupal_get_install_files() where it calls the function drupal_system_listing(). What happens is if we are turned on the search module, a regex mask is passed into drupal_system_listing() of the form 'search.install$'. Unfortunately this returns installation files for all modules whose names end in the word search... So instead of just running the install for the search module, we get the installation process for the search, apachesolr_search, and acquia search (assuming we're using an Acquia release of Drupal).

CommentFileSizeAuthor
#3 core-install-profiles-toomany-installs-451190-3.patch736 bytesJimBroad

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Postponed (maintainer needs more info)

No doubt this is a bug, we are loading all the install files for all the *search modules when installing the search module, but how does that lead to additional modules being installed?

In the meantime, bumping to D7, because the bug is there too.

Gekiboy’s picture

Gekiboy commented

Sorry, it doesn't actually install the module but rather runs the installation function. For some reason that's beyond me currently this causes the installation of my custom profile to completely error out. I tracked it down to this point and realized the problem was in core code and I didn't want to change and patch it without knowing what the reasoning was.

JimBroad’s picture

JimBroad commented
StatusFileSize
new core-install-profiles-toomany-installs-451190-3.patch736 bytes

Think I just ran into this as well...

and I believe the issue is here:
http://api.drupal.org/api/drupal/includes--install.inc/function/drupal_g...

drupal_system_listing() is called and given a mask of $module .'.install$'
I think the mask should be '^'. $module .'.install$'

I have have attached patch against 6.x-dev

dddave’s picture

dddave commented
Status: Postponed (maintainer needs more info) » Needs review

Correcting status...

Status: Needs review » Needs work

The last submitted patch, core-install-profiles-toomany-installs-451190-3.patch, failed testing.

David_Rothstein’s picture

David_Rothstein commented
Title: Installing a module via a custom installation profile installs additional modules » Modules which have similar names as modules in the install profile get their installation requirements checked

Trying to give this a more accurate title, based on discussion in #875406: drupal_get_install_files returns contrib/custom modules (which is duplicate).

The patch looks reasonable on a quick glance. I think this is only an issue in 6.x now (the equivalent code no longer exists in 7.x).

David_Rothstein’s picture

David_Rothstein commented
Status: Needs work » Needs review

#3: core-install-profiles-toomany-installs-451190-3.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, core-install-profiles-toomany-installs-451190-3.patch, failed testing.

JimBroad’s picture

JimBroad commented
Status: Needs work » Needs review

#3: core-install-profiles-toomany-installs-451190-3.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, core-install-profiles-toomany-installs-451190-3.patch, failed testing.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs work » Needs review

The patch applies fine, so I'm setting this back to "needs review".

gease’s picture

gease
he/him
Primary language Russian
Location Praha
commented

Works fine, should be rolled into the next release, imho.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.