Sun reminded me that since Drupal 6 we've run updates for disabled modules, however we didn't update the documentation.

4. If using a custom or contributed theme, switch
to a core theme, such as Garland or Bluemarine.

5. Disable all custom and contributed modules.

Is there any other reason to disable contrib modules? If not we should remove it. I think we should also improve the distinction between minor and major upgrades, but that's out of scope here.

CommentFileSizeAuthor
#8 upgrade.patch776 bytesmcrittenden

Comments

AmrMostafa’s picture

AmrMostafa commented

Thanks for submitting this, I need to keep this on my watch list, definitely very important, but I gotta run now

catch’s picture

catch
he/him
Primary language English
commented

I actually found a reason to disable contrib modules yesterday - I've been needing to run dummy d6 and d7 updates - both have devel module installed (and enabled in D6). In devel, on update.php it tries to call user_access() - but user_access() doesn't work because user_role_permissions has been renamed.

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented
Title: Upgrade instructions recommend enabling stark in D6 » Upgrade instructions are out of date

Mentioned this issue in the D6 to D7 upgrade meta issue #563106: Cannot upgrade from Drupal 6 to Drupal 7 - meta issue.

Also, does it qualify as critical?

catch’s picture

catch
he/him
Primary language English
commented

I think we need to determine what the current best practice is and have this reflected in the documentation, but that's probably not critical.

However the instructions currently recommend switching to Stark before you upgrade. Except for the fact that there's no Stark theme in D6, whoops. That's trivial to fix, but we can't ship with it, so leaving priority unchanged for now.

catch’s picture

catch
he/him
Primary language English
commented
Title: Upgrade instructions are out of date » Upgrade instructions recommend enabling stark in D6
psynaptic’s picture

psynaptic commented
Title: Upgrade instructions are out of date » Upgrade instructions recommend enabling stark in D6

I have never switched themes or disabled any modules when doing an upgrade. Maybe I'm just extremely lucky but I have never had a problem.

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: +Quick fix

Maybe a tag will help this one line trivial patch get written...

mcrittenden’s picture

mcrittenden commented
Status: Active » Needs review
StatusFileSize
new upgrade.patch776 bytes

Patch attached.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Priority: Critical » Minor
Status: Reviewed & tested by the community » Fixed

Oopsie. :) Committed to HEAD.

Guys, let's please watch the definition of 'critical', ok? :P Confusing upgrade instructions have been a 'feature' since Drupal 1. ;)

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.