Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This line in system.install:
'description' => 'A flag indicating whether file is temporary (1) or permanent (0).',
I've peered at my files table and I'm pretty sure the 0 ones are the temporary ones -- so that line of comment has it the wrong way round.
(Also, when you add a status field in views, it tells you the 0 means temporary.)
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 437822-fixd6.patch | 738 bytes | jhodgdon |
| #2 | 437822.patch | 992 bytes | jhodgdon |
Comments
Comment #1
jhodgdonI think joachim is correct. It is also incorrect in Drupal 7.
See:
- http://api.drupal.org/api/function/system_schema/7 (table "files", field "status"), where it says "'A bitmapped field indicating the status of the file the least sigifigant bit indicates temporary (1) or permanent (0). Temporary files older than DRUPAL_MAXIMUM_TEMP_FILE_AGE will be removed during a cron run.
- http://api.drupal.org/api/function/system_cron/7 where it removes files with status bit not equal to FILE_STATUS_PERMANENT
- http://api.drupal.org/api/constant/FILE_STATUS_PERMANENT/7 (defined to be 1).
Significant is also misspelled in the D7 doc.
Comment #2
jhodgdonHere's a D7 patch.
Would we patch D6 for this? I wasn't sure if it would fall under string freeze. Anyway, D7 first...
Comment #4
jhodgdonSetting back to Needs Review in hopes that the patch will get retested. The test bot was apparently malfunctioning (I had about 7 patches fail in that time period, all were doc, none broke the HEAD install I am pretty sure).
Comment #6
jhodgdonTest bot problem
Comment #7
dries commentedCommitted to CVS HEAD. Thanks!
Comment #9
xjmOpen issue for this in 6.x at #292686: files.status documented with opposite values.
Comment #10
jhodgdonOh. We should reopen this issue and port to D6.
Comment #11
joachim commentedI'm guessing that patch will work on D6.
Will setting to needs review make the bot try it on 6?
Comment #12
jhodgdonThe test bot won't go back and test past patches unless you hit "retest".
Anyway, the patch doesn't apply in D6...
How about this?
Comment #13
joachim commentedI think we can RTBC that without bot approval :)
Comment #14
gábor hojtsyCommitted, thanks.