The salutation string is untranslatable and consists only of the user name. If the user name is the surname or the full name this is unacceptable, at least in german.

Please make it translatable like in the attached patch. Better would be a configurable solution, like for the site-wide contact form.

CommentFileSizeAuthor
#9 417244-contact-be-polite-D7.patch1.33 KBdave reid
#5 417244-contact-be-polite-D7.patch1.29 KBdave reid
#3 417244-contact-be-polite-D7.patch1.5 KBdave reid
contact.module.patch1.11 KBarnd

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 6.10 » 7.x-dev
Category: feature » bug

We should use some sort of approach like:
t('Hello @username,', array('@username => $account->name))

Also must be fixed in Drupal 7 (HEAD) first.

Also marked #514798: Be more polite in contact mail as a duplicate of this.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: salutation in email sent from personal contact form can be extremely impolite » Contact mail greeting should be friendly and translatable
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 417244-contact-be-polite-D7.patch1.5 KB

Patch attached for review.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Assigned: Unassigned » dave reid
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 417244-contact-be-polite-D7.patch1.29 KB

Re-rolled for latest changes.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Reasonable and good for translation!

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

mattyoung’s picture

mattyoung commented

.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 417244-contact-be-polite-D7.patch1.33 KB

Re-rolled only.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.