If no forum containers have been created, when you try to navigate to the forums, there is a blank page... as in... nothing... no theme... view source? nada... zilch...

CommentFileSizeAuthor
#1 forum.empty.patch764 bytesspiderman

Comments

spiderman’s picture

spiderman
he/any
Primary language English
Location Guelph, ON
commented
Assigned: Unassigned » spiderman
Status: Active » Needs review
StatusFileSize
new forum.empty.patch764 bytes

confirmed this bug, and found the source- the module_exist() checks at the start of forum_page only confirm that the comment.module and taxonomy.module are enabled, but don't determine whether there are any forum terms defined in the taxonomy yet. the patch moves the forum_get_forums($tid) call up, and then includes an extra check in the if statement, to determine whether there are forums to list.

Steve Dondley’s picture

Steve Dondley commented
Priority: Critical » Normal

downgrading to normal. hardly a showstopper.

q0rban’s picture

q0rban commented

right you are.. no idea why it was originally marked "critical"... my mistake i suppose

dries’s picture

dries commented

This is not the proper fix. If theme_forum_display is called without forums, it should output an error message. It already attempts to but maybe something is broken in that code. Please check.

dries’s picture

dries commented
Status: Needs review » Needs work
veelo’s picture

veelo commented
Title: blank page when no forums have been created » blank page when no forums have been created or no access to forums
Version: 4.7.0-beta2 » 4.7.0-beta4

Note that the blank page also shows up for users that have no access to existing forums.

I got bitten by this after an upgrade from 4.5.7 to 4.7.0-beta4, where my forum stopped working. this is due to a change in behaviour together with the taxonomy_access module. I have an obligatory dedicated "Access" category in which I have defined several levels of access. Previously, users that did not have access to the forum itself but to forum posts with a certain access level, could see the post and the forum containing it, but not other forum posts that they did not have access to. In other words, my "Access" category took preference over the forum category in determining access.

Now, I have to explicitly give access to the forum term in order to show the forum. What is worse, is that to give users with a low level of access the possibility to see the forum, they can read all forum posts, also the ones with a higher level of "Access" term.

I am probably going to file a bug on this change of behaviour some place more appropriate -- I don't know whether it is the forum module or the taxonomy_access module or something else that is to blame.

But maybe we should upgrade the priority of this bug to critical because i thought the upgrade broke my forum. If I would have found a forum page with no forums listed, I would probably have searched into access matters earlier...

Egon Bianchet’s picture

Egon Bianchet commented
Version: 4.7.0-beta4 » 4.7.0
Status: Needs work » Closed (fixed)

I can't reproduce this in 4.7.0 ... looks like it's been fixed.