Reproduce:

- add feed to aggregator
- go to aggregator/sources/1

Next to the URL: label you will see a link to your own site. The reason is that aggregator hasn't downloaded the feed yet and the feed link (link to the feed's web site) is not available yet.

Patch follows asap.

CommentFileSizeAuthor
#20 drupal-aggregator-fix-link-397962-20-D7.patch3.63 KBsmussbach
#13 drupal-aggregator-fix-link-397962-13.patch3.54 KBrootwork
#12 drupal-aggregator-fix-link-397962-12.patch0 bytesrootwork
#7 397962_fix_feed_link.patch2.73 KBalex_b
#1 397962_fix_feed_link.patch1.97 KBalex_b

Comments

alex_b’s picture

alex_b commented
StatusFileSize
new 397962_fix_feed_link.patch1.97 KB
alex_b’s picture

alex_b commented
Issue tags: +Quick fix
alex_b’s picture

alex_b commented
Assigned: alex_b » Unassigned
alex_b’s picture

alex_b commented
Status: Active » Needs review
alex_b’s picture

alex_b commented
Status: Needs review » Reviewed & tested by the community

Passed test bot, simple fix, setting it to RTBC.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

If the feed hasn't been downloaded yet, shouldn't we skip the description, image, and friends too? The code is somewhat inconsistent -- for the 'checked' check we use a regular if-statement. It feels like this can be cleaned up further, maybe even with a test update.

alex_b’s picture

alex_b commented
Status: Needs work » Needs review
StatusFileSize
new 397962_fix_feed_link.patch2.73 KB

#6 - that's right... this patch hides any information retrieved from feed if the feed hasn't been updated yet - much cleaner.

alex_b’s picture

alex_b commented
Status: Needs review » Postponed

Let's hold on this one for the moment. #293318: Convert Aggregator feeds into entities may completely change template_preprocess_aggregator_feed_source() anyway.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
Version: 7.x-dev » 8.x-dev
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Postponed » Active

as per #8

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented

Should be after #1896060: aggregator.module - Convert PHPTemplate templates to Twig, not?

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
commented
Issue summary: View changes
Status: Active » Needs review
Issue tags: +SprintWeekend2014
StatusFileSize
new drupal-aggregator-fix-link-397962-12.patch0 bytes

Took a stab at updating this. First I confirmed that it is still true in Drupal 8 -- if the feed hasn't been retrieved yet, it will display your own site's address as the feed address.

I made the corresponding changes to the aggregator page and the new Twig template, but it's not functioning yet -- I suspect because I'm not yet familiar with how variable checking in Twig works. If you someone else wants to try to get it to work, that's where I'd start.

Setting to needs review so the testbot will run, but it needs more work.

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
commented
StatusFileSize
new drupal-aggregator-fix-link-397962-13.patch3.54 KB

Oops. Here's the real patch.

The last submitted patch, 12: drupal-aggregator-fix-link-397962-12.patch, failed testing.

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
commented

13: drupal-aggregator-fix-link-397962-13.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 13: drupal-aggregator-fix-link-397962-13.patch, failed testing.

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
commented
Status: Needs work » Needs review

13: drupal-aggregator-fix-link-397962-13.patch queued for re-testing.

znerol’s picture

znerol commented
Status: Needs review » Patch (to be ported)

This was fixed by #2261425: Streamline aggregator's entities rendering with rest of core for Drupal 8.0.x. Still an issue in 7.x, though.

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
commented
Version: 8.0.x-dev » 7.x-dev
smussbach’s picture

smussbach commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new drupal-aggregator-fix-link-397962-20-D7.patch3.63 KB

Here is the patch ported for D7

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.