This is a blocker for PIFT 2.x.

CommentFileSizeAuthor
#2 run_tests_remove.patch2.97 KBboombatower
#1 run_tests_remove.patch2.97 KBboombatower
run_tests_remove.patch2.12 KBboombatower

Comments

boombatower’s picture

boombatower commented
StatusFileSize
new run_tests_remove.patch2.97 KB

Updated to make it re-usable. (simpletest.module/run-tests.sh patch to follow).

boombatower’s picture

boombatower commented
StatusFileSize
new run_tests_remove.patch2.97 KB

Condition was backwards. (won't show up in tests...since minor user message meant for dev.)

boombatower’s picture

boombatower commented
Status: Needs review » Reviewed & tested by the community

Per chx's review.

chx’s picture

chx commented

Right.

boombatower’s picture

boombatower commented

Description:

The run-tests.sh script ignores the variable simpletest_clear_results and removes the SimpleTest test results regardless of its value, where as SimpleTest.module follows the condition.

This patch creates a common function that both places call which follows the condition.

This is necessary for PIFR 2.x because it will read results directly out of database.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Discussed with chx and boombatower in #drupal. We have a variable called 'simpletest_clear_results' which will leave the old testing results in the database (by design) if set to false. This data can be used by the testing bot to retrieve a list of the specific tests that failed. However, since the testing bot runs run-tests.sh and not the browser-based SimpleTest, it failed to respect this setting and cleared the tables regardless.

Straight-forward patch, has approval from both testing system maintainers. Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.