The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.As per coding standards, we should use SELECT COUNT(*) instead of SELECT count(*) (SQL reserved words should be capitalized.
I see a few count() in SQL queries in:
modules/aggregator/aggregator.admin.inc (1)
modules/simpletest/tests/database_test.test (many here!)
and in:
modules/taxonomy/taxonomy.admin.inc (1).
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 373775.diff | 7.25 KB | soghad |
| #2 | 373775-database-test-inc.diff | 4.92 KB | soghad |
| #2 | 373775-taxonomy-admin-inc.diff | 1.28 KB | soghad |
| #1 | 373775.aggregator.admin_.inc_.patch | 980 bytes | soghad |
Comments
Comment #1
soghad commentedFixed in aggregator.admin.inc
Comment #2
soghad commentedFixed in:
/modules/simpletest/tests/database.test.inc
and
/modules/taxonomy/taxonomy.admin.inc
Comment #4
dave reidI was confused...your issue's title was backwards from what you were actually trying to accomplish.
Comment #5
recidive commented@sog_hadgraft: try to put all your changes on a single patch, with paths relative to Drupal root directory, otherwise test bot won't be able to apply it.
Check Creating patches documentation for help.
Comment #6
soghad commentedThanks for the tip. In this latest post, I've included everything in one patch and created the diff relative to root.
Comment #7
dave reidI did a quick grep and couldn't find any more. Looks good and the testbot likes.
Comment #8
dries commentedCommitted to CVS HEAD. Thanks!