in:

/includes/database/mysql/database.inc

on line 18, line is

$this->transactionSupport = !empty($connection_option['transactions']);

and should be

$this->transactionSupport = !empty($connection_options['transactions']);

($connection_option -> $connection_options).

this preveents transactions from being enabled since it always returns false

CommentFileSizeAuthor
#3 drupal-7-dev-373514-1.patch595 bytesjbomb

Comments

Crell’s picture

Crell commented

Hm, right you are. Can you roll a quick patch?

karschsp’s picture

karschsp commented
Issue tags: +Novice

Tagging for novice queue.

jbomb’s picture

jbomb commented
StatusFileSize
new drupal-7-dev-373514-1.patch595 bytes

requested patch from #1 with jaydee18's fix

jbomb’s picture

jbomb commented
Status: Active » Needs review
Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Thanks!

dries’s picture

dries commented

It looks good to me, but I wonder why the tests work without this patch ... should we look at fixing our tests?

Crell’s picture

Crell commented

The test bot only runs MyISAM right now, so it's not actually testing transaction logic. Known issue, has not yet been solved, but not something we can solve in this patch.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.