This functionality is forked off of #371374: Add ImageCache UI Core and based on code that's been in ImageCache for quite a while.

CommentFileSizeAuthor
#12 filefield_363960.patch879 bytesdrewish
#13 file_373502.patch9.13 KBdrewish
#11 file_373502.patch9.13 KBdrewish
#10 file_373502.patch7.9 KBdrewish
#9 drupal7-sun.file-delete-recursive___.patch7.94 KBsun
#8 drupal7-sun.file-delete-recursive__.patch7.84 KBsun
#7 drupal7-sun.file-delete-recursive_.patch7.82 KBsun
#5 drupal7-sun.file-delete-recursive.patch7.92 KBsun
#4 file_373502.patch8.12 KBdrewish
#2 file_373502.patch7.99 KBdrewish
file_delete_recursive.patch6.2 KBdrewish

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

drewish’s picture

drewish commented
Status: Needs work » Needs review
StatusFileSize
new file_373502.patch7.99 KB

fixing a bug in the tests and a missed replacement of simpletest_clean_temporary_directory() with file_unmanaged_delete_recursive().

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Straightforward. Only very minor issues:

+  // Catch all for other types of files like sockets.

...I had to read twice to understand.

+
+

Doubled blank lines in file.test.

If the tests will pass and those very minor issues are fixed, this is RTBC.

drewish’s picture

drewish commented
StatusFileSize
new file_373502.patch8.12 KB

thanks sun, fixed those issues.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new drupal7-sun.file-delete-recursive.patch7.92 KB

We can also provide some return value. Slightly simplified that comment.

drewish’s picture

drewish commented

sun, i intentionally did not return a value since you'd really need to check the whole way down the tree.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new drupal7-sun.file-delete-recursive_.patch7.82 KB

Removed the return value.

But also fixed some coding-style issues. Yikes!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new drupal7-sun.file-delete-recursive__.patch7.84 KB
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new drupal7-sun.file-delete-recursive___.patch7.94 KB
drewish’s picture

drewish commented
StatusFileSize
new file_373502.patch7.9 KB

how about this so we avoid checking is_file is_link over and over?

drewish’s picture

drewish commented
StatusFileSize
new file_373502.patch9.13 KB

okay, now with return value. and better docs.

drewish’s picture

drewish commented
StatusFileSize
new filefield_363960.patch879 bytes

what a beautiful bikeshed we've built!

[ignore this... wrong patch]

drewish’s picture

drewish commented
StatusFileSize
new file_373502.patch9.13 KB

with an extra the now.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Excellent work, folks. :) Committed to HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -D7FileAPIWishlist, -ImageCacheInCore

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +D7FileAPIWishlist, +ImageCacheInCore

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.