Problem/Motivation

We should ship 12.0.0 with the latest versions of our PHP dependencies.

Steps to reproduce

Proposed resolution

composer update

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3638867

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

godotislate created an issue. See original summary.

godotislate’s picture

godotislate’s picture

Status: Active » Needs review

Since we just updated to PHPStan 2.3.5 in #3635620: Bump PHPStan to version 2.3.5 and friends, I kept it at that version (2.3.6 is available). That said, other PHPStan-related packages did get updated which seemed to necessitate changes to the baseline and one minor code change.

I did run into PHPStan passing locally and failing on CI, and based on what I've seen in other issues, there does sometimes seem to be a delta, which might be worth look into as a follow up if it continues to pop up.

Lock diff:

+---------------------------+---------+---------+
| Production Changes        | From    | To      |
+---------------------------+---------+---------+
| composer/semver           | 3.4.4   | 3.6.0   |
| doctrine/lexer            | 3.0.1   | 3.0.3   |
| guzzlehttp/guzzle         | 8.2.0   | 8.5.1   |
| guzzlehttp/promises       | 3.0.2   | 3.1.0   |
| guzzlehttp/psr7           | 3.1.0   | 3.4.0   |
| justinrainbow/json-schema | 6.12.0  | 6.14.0  |
| mck89/peast               | v1.18.0 | v1.18.1 |
| twig/html-extra           | v3.28.0 | v3.29.0 |
| twig/twig                 | v3.28.0 | v3.30.0 |
+---------------------------+---------+---------+

+----------------------------------+---------+---------+
| Dev Changes                      | From    | To      |
+----------------------------------+---------+---------+
| brick/math                       | 0.18.0  | 1.0.0   |
| composer/class-map-generator     | 1.7.3   | 1.9.0   |
| composer/composer                | 2.10.3  | 2.11.2  |
| doctrine/deprecations            | 1.1.6   | 1.2.0   |
| doctrine/instantiator            | 2.1.0   | 2.2.0   |
| google/protobuf                  | v5.36.1 | v5.36.2 |
| mglaman/phpstan-drupal           | 2.3.0   | 2.4.0   |
| nikic/php-parser                 | v5.8.0  | v5.9.0  |
| open-telemetry/api               | 1.10.0  | 1.11.0  |
| open-telemetry/context           | 1.5.0   | 1.6.0   |
| open-telemetry/exporter-otlp     | 1.4.0   | 1.5.0   |
| open-telemetry/gen-otlp-protobuf | 1.10.0  | 1.11.1  |
| open-telemetry/sdk               | 1.15.0  | 1.16.1  |
| open-telemetry/sem-conv          | 1.38.0  | 1.45.0  |
| phpdocumentor/reflection-common  | 2.2.0   | 2.2.1   |
| phpdocumentor/type-resolver      | 2.0.0   | 2.1.0   |
| phpstan/phpdoc-parser            | 2.3.5   | 2.4.1   |
| phpstan/phpstan-phpunit          | 2.1.1   | 2.1.2   |
| phpunit/php-code-coverage        | 12.5.7  | 12.5.8  |
| phpunit/php-text-template        | 5.0.0   | 5.0.1   |
| phpunit/phpunit                  | 12.5.34 | 12.5.44 |
| ramsey/uuid                      | 4.9.3   | 4.10.0  |
| sebastian/version                | 6.0.0   | 6.0.2   |
| seld/jsonlint                    | 1.12.1  | 1.12.2  |
| seld/phar-utils                  | 1.2.2   | 1.2.3   |
| slevomat/coding-standard         | 8.31.1  | 8.31.3  |
| spaze/phpstan-disallowed-calls   | v4.15.0 | v4.15.1 |
| vincentlanglet/twig-cs-fixer     | 4.1.1   | 4.1.2   |
| webmozart/assert                 | 2.4.1   | 2.5.1   |
+----------------------------------+---------+---------+
mondrake’s picture

Can't we bump PHPStan too? What's holding?

godotislate’s picture

Can't we bump PHPStan too? What's holding?

I'm fine with that, but I wonder if we shouldn't do that in one more separate issue like #3635620: Bump PHPStan to version 2.3.5 and friends before the RC (so we stop chasing it), so that we keep main, 12.0.x, 11.x, and 11.5.x in sync and reduce the incidences for baseline conflicts on backports. In which case, I should probably revert the changes to the PHPStan friends here.

But I'm fine either way.

mondrake’s picture

Status: Needs review » Reviewed & tested by the community

Keeping aligned is a good point.