Problem/Motivation

Default Admin's css/components/update.css has selectors for the contributed Upgrade Status module:

  • .drupal-upgrade-status-summary-form tr.no-known-error
  • .upgrade-status-next-step-remove tr
  • .drupal-upgrade-status-summary-form tr.known-warnings
  • .drupal-upgrade-status-summary-form tr.known-errors

A core theme shouldn't style a contributed module. These rules came from Gin.

They also don't event match anything anymore. Upgrade Status no longer uses these classes in favour of the generic color-success, color-warning and color-error classes, which the same file already styles.

Found in #3590168: Special styles for "Default Admin" theme in Drupal 12.

Problem applies to 11.x, 12.0.x and main.

Proposed resolution

Remove the four module specific selectors from css/components/update.pcss.css, and rebuild
css/components/update.css.

Remaining tasks

Review.

User interface changes

None. The selectors don't match current Upgrade Status markup.

API changes

None.

Data model changes

None.

LLM disclosure

LLM was used to find and resolve this issue. With human review.

Issue fork drupal-3636246

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

gábor hojtsy created an issue. See original summary.

gábor hojtsy’s picture

Status: Active » Needs review
mherchel’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me! Thanks :)