Problem/Motivation

We should ship 11.5.0 with some updated dependencies.

Steps to reproduce

Proposed resolution

Update whatever we can without breaking changes.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3625623

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !17233

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

This updates:

@floating-ui/dom
chokidar
dotenv
glob
postcss-preset-env
prettier
sortablejs
stylelint
stylelint-config-standard
stylelint-order
tabbable
terser
tua-body-scroll-lock
webpack
webpack-cli

There was a problem in the build: yarn install; yarn vendor-update overwrites CKEditor with 47.6.2 as 47.6.3 does not exist in npm. I manually reverted this but it will happen again if we update again.

I also didn't update transliteration here as there is a breaking change - the global variable used to access the library has changed - and I don't think we should force that on 11.x users just in case they are using the library directly.

godotislate’s picture

godotislate
he/him
commented

Other than transliteration which was updated here per #3, I tried a vendor update locally and there were a few more that were not included:
postcss: 8.5.16 -> 8.5.28
postcss-import: 16.1.1 -> 17.0.0
jsdom : 27.4.0 -> 30.1.1
js-cookie: 3.0.5 -> 3.0.8
htmx.org: 2.0.10 -> 2.0.11

Some of these might just be new releases since the MR, but do we want to do the postcss and js-dom updates to match main?

Also, from Carson Gross in Slack:

Just released htmx 2.0.11 w/a back port of hx-partial from htmx 4

Do we want to do this? Maybe in a separate issue?

One other thing is whether we want to update cspell to match main as well, since it looks like CI is running node 24 in the 11.x builds anyway, but could either be a new issue or we could re-open #3621993: Update Cspell for a backport.

Otherwise, if we're fine without updating these other libraries, this lgtm.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

In the 12.0.0 issue we deferred PostCSS and postcss-import to #3625308: Update postcss, and postcss-import for Drupal 12 as it causes a noisy diff.

Not sure how I missed jsdom here, we should update js-cookie and htmx as well. We might want a separate issue to add PHP support for hx-partial if we need it as well.

Drupal 11 only had Node 20 as the development requirements and I'm not sure we should bump that here, although I'm also not sure who it would affect outside of core developers.

godotislate’s picture

godotislate
he/him
commented
Status: Needs work » Needs review

Updated additional packages per #5 and any outstanding since the original MR commits:

dotenv -------------------------------------- ◯ ^18.0.1 ------ ◉ ^18.0.6 ------
htmx.org ------------------------------------ ◯ 2.0.10 ------- ◉ 2.0.11 -------
js-cookie ----------------------------------- ◯ ^3.0.5 ------- ◉ ^3.0.8 -------
jsdom --------------------------------------- ◯ ^27.4.0 ------                  ◉ ^30.1.2 ------
postcss-preset-env -------------------------- ◯ ^11.5.3 ------ ◉ ^11.6.1 ------
prettier ------------------------------------ ◯ ^3.9.8 ------- ◉ ^3.9.9 -------
stylelint ----------------------------------- ◯ ^17.15.0 ----- ◉ ^17.16.0 -----

Updating js-cookie required changing the hash in its deprecation test.

We might want a separate issue to add PHP support for hx-partial if we need it as well.

I assume if we do this, it would need to be before we release 11.5 beta?

godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev
godotislate’s picture

godotislate
he/him
commented

Looks like there isn't anything on the PHP side to do for hx-partial support in 11.x/11.5.x, so we there's nothing to worry about for 11.5 beta.
Per @fathershawn on Slack:

hx-partial is a render strategy that we are currently implementing in PHP via the inline template.