Problem/Motivation

This schema file has:

name:
type: label
label: 'Name'

but the matching config entity type has:

config_export: [
'id',
'label',
],

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3624237

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

leandro713’s picture

leandro713 commented
Assigned: Unassigned » leandro713
leandro713’s picture

leandro713 commented

I would like to work on this issue, but before changing the schema I
noticed that both the entity key mapping and the installed test
configuration use `name`:

- The `label` entity key maps to `name`.
- `module_installer_config_test.type.missing_id.yml` contains `name`.

Only `config_export` uses `label`.

Would the intended minimal fix be to change `config_export` from
`label` to `name`, rather than changing the schema?

leandro713 opened merge request !17199

leandro713’s picture

leandro713 commented
Status: Active » Needs review

The merge request updates the test entity's `config_export` definition to use
`name`, making it consistent with the entity key mapping, configuration schema,
and installed test configuration.

Checks performed:

- PHPCS: passed.

joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

> Would the intended minimal fix be to change `config_export` from
`label` to `name`, rather than changing the schema?

I think that's the right fix -- I hadn't investigated far enough when I filed the issue.

Thanks!

quietone’s picture

quietone commented
Title: incorrect schema in core/modules/system/tests/modules/module_installer_config_test/config/schema/module_installer_config_test.schema.yml » incorrect schema in module_installer_config_test.schema.yml
Assigned: leandro713 » Unassigned

There is only on module_installer_config_test.schema.yml file in core, so trimming the title/