Problem/Motivation

Our cspell dictionaries have words like "subtheme's" even though we already include the word "subtheme", and cspell already handles this. These only exist in the dictionaries because our tooling to generate the dictionary automatically includes them.

Steps to reproduce

yarn spellcheck:make-dict or yarn spellcheck:make-drupal-dict.

Proposed resolution

Expand the commands to strip 's from the end of each word using sed or similar.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3623854

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !17163

mstrelan’s picture

mstrelan commented
Status: Active » Postponed

Postponed on #3621993: Update Cspell since the first commit will conflict. Can review the other two commits.

mstrelan’s picture

mstrelan commented
Status: Postponed » Needs review
quietone’s picture

quietone commented

Is there a problem with remove "'s" for any non English language?

mstrelan’s picture

mstrelan commented

I don't understand the question since we only use cspell to make sure Drupal is written in American English.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

The changes look OK to me. The new sed command replaces any "'s" strings with nothing. Any duplications that result are removed by the following sort command.

All nine existing possessives that exist across the two dictionaries are deleted by the changes.

I think this one is good to go.