Problem/Motivation

The work to remove the deprecate code in ajax.js did not get completed in time for removal in Drupal 12. So, change the removal to Drupal 13.

#3352549: Remove deprecations in ajax.js

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3623168

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Issue tags: +12.0.0 release priority
shahul hameed’s picture

shahul hameed commented

I checked the current `main` branch and the deprecation notices in `core/misc/ajax.js` already state that the code is removed in Drupal 12.0.0.

I also checked the issue fork branch `3623168-update-deprecation-notices`; it currently has no changes compared with `main`.

Could you clarify what additional change is still required for this issue, or whether this issue is intended to track/release the change already made?

quietone’s picture

quietone commented
Issue summary: View changes

@shahul hameed, thanks, I have corrected the issue summary

shahul hameed opened merge request !17171

abenbow’s picture

abenbow
He/Him/His
Primary language English
commented
Status: Active » Reviewed & tested by the community

I have reviewed the MR that @shahul made and it appears to satisfy the requirements of this issue. Given that this is essentially a documentation change, I don't see a high risk for merging it.

There is a failing job on the MR in the Nightwatch test suite, but it doesn't appear related to his work.

    Error location:
    /builds/core/tests/Drupal/Nightwatch/Tests/jQueryUIPositionShimTest.js:1488
    ––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––
     1486 |         Object.entries(result.value).forEach(([key, value]) => {
     1487 |           browser.assert.equal(typeof value, 'object');
     1488 |           browser.assert.deepEqual(value.actual, value.expected, key); 
     1489 |         });
     1490 |       },
    ––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––––
 Wrote HTML report file to: /builds/nightwatch_output/nightwatch-html-report/index.html

https://git.drupalcode.org/issue/drupal-3623168/-/jobs/12262526

  • quietone committed 938f02a4 on 11.4.x 
    task: #3623168 Update deprecation notices in ajax.js

By: shahul hameed...

  • quietone committed 464824e1 on 11.x 
    task: #3623168 Update deprecation notices in ajax.js

By: shahul hameed...

  • quietone committed 6b3b3693 on main 
    task: #3623168 Update deprecation notices in ajax.js

By: shahul hameed...
quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 6b3b3693741 to main and 464824e16b9 to 11.x and 938f02a4f04 to 11.4.x.

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

shahul hameed’s picture

shahul hameed commented
Status: Fixed » Active

@quietone Tested the proposed change in `core/misc/ajax.js`.

The deprecation notices now reference Drupal 13 for removal.

Pipeline results:

* JavaScript linting: passed
* PHP coding standards: passed
* PHPStan: passed
* PHPUnit Kernel: passed
* PHPUnit Functional: passed
* PHPUnit Functional JavaScript: passed
* Nightwatch: failed in `Tests/jQueryUIPositionShimTest` with 2 assertions failing and 1,251 passing. The failure is in the jQuery UI position shim test and is unrelated to the `ajax.js` deprecation notice change.

Tugboat preview also completed successfully.

shahul hameed’s picture

shahul hameed commented
Status: Active » Fixed

Restoring the issue status to Fixed. My previous testing comment accidentally changed the status from Fixed to Active.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

quietone commented

@shahul hameed, thanks for following up. For Drupal core, there is no need to provide a details of the passed tests because we can see them by following the link to the test results that are in the Issue Fork section of the Issue Summary. In this case, it is red because of the Nightwatch test failure. And I checked the test results before pushing this change, so I knew it was Nightwatch. Also, this is a doc only change and it should only cause linting failures.

Cheers