Problem/Motivation

In #3505370: Remove 'filter tips' page and deprecate the long format API we deprecated the filter tips page for long filter tips. In #3575254: Module deprecation removal part2 we deleted \Drupal\filter\Hook\FilterThemeHooks::preprocessFilterTips. We still render filter-tips.html.twig but since the preprocess is gone, we never see any filter tips. This was found in #3471113: Update to selenium/standalone-chrome:134+ where CKEditor5AllowedTagsTest is consistently failing in newer versions.

Steps to reproduce

  • Install demo umami on main
  • Log in as admin
  • Go to /node/add/page
  • Change text format to "Restricted HTML"

Proposed resolution

Restore \Drupal\filter\Hook\FilterThemeHooks::preprocessFilterTips and the initial preprocess from FilterThemeHooks::theme

Move test coverage out of CKEditor5AllowedTagsTest

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3621903

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan’s picture

mstrelan commented
Issue summary: View changes

hoxton made their first commit to this issue’s fork.

hoxton’s picture

hoxton commented

Partial revert of 49c2dc1 for 'preprocessFilterTips' and 'initial preprocess'.
But removed the description of 'long' optional field to variables in 'preprocessFilterTips' as its deprecated under https://www.drupal.org/node/3567879.

hoxton opened merge request !17060

hoxton’s picture

hoxton commented
Status: Active » Needs review
mstrelan’s picture

mstrelan commented
Status: Needs review » Needs work

Fails coding standards, added suggestions. There is still a reference to $long that needs to be removed.

I think we should move the filter tips test coverage out of CKEditor5AllowedTagsTest.

mstrelan’s picture

mstrelan commented

@hoxton there are still some coding standards errors you can see here: https://git.drupalcode.org/issue/drupal-3621903/-/jobs/12103471

FILE: /builds/core/modules/filter/src/Hook/FilterThemeHooks.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 96 | ERROR | [x] Expected 1 blank line after function; 0 found
    |       |     (Squiz.WhiteSpace.FunctionSpacing.After)
--------------------------------------------------------------------------------
mstrelan’s picture

mstrelan commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Appears to be missing part Move test coverage out of CKEditor5AllowedTagsTest