Problem/Motivation

ThemeNegotiator injects the class resolver and the service IDs of all theme negotiators, then loops over the services in turn.

A tagged iterator provides the same capability without needing the class resolver.

Steps to reproduce

Proposed resolution

Replace the class resolver and service_id_collector tag with a tagged iterator.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3621531

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave-bot made their first commit to this issue’s fork.

longwave opened merge request !17036

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

I don't think this requires BC, I don't see why you would override this service, but happy to try to add some if someone deems it necessary.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Think @nicxvan comments makes sense. Not 100% about the autowiring the iterators but comment cleanup and constructor promotion seem doable right?