Problem/Motivation
Change use of Claro in comments but not in tests.
$ git grep -ni claro | grep -v core/assets | grep -v .phpstan-baseline.php | grep -v core/themes/claro | grep -v core/modules/toolbar | grep -v core/themes/olivoer | grep -v tests | grep -E "\s*(//|#|\*|{\s*#)"
But some can't be made until Admin is stable.
Steps to reproduce
Proposed resolution
- core/lib/Drupal/Component/Plugin/DependentPluginInterface.php
- core/lib/Drupal/Core/Field/FieldItemInterface.php
- core/lib/Drupal/Core/Render/theme.api.php
- core/modules/help/tests/src/Functional/HelpTopicTranslatedTestBase.php
- core/tests/Drupal/FunctionalTests/Installer/StandardInstallerTest.php
- core/tests/README.md
- core/recipes/core_recommended_admin_theme/recipe.yml - done in #3582101: Make Admin the default theme in profiles and recipes
- core/themes/default_admin/images/core/README.md - Do this as part of making Default Admin stable
- core/themes/olivero/templates/filter/filter-tips.html.twig - Can remain as Olivero is being deprecated
Make a separate issue to move the CSS per the comments in the file
- core/misc/dialog/off-canvas/css/form.pcss.css
- core/misc/dialog/off-canvas/css/throbber.pcss.css
- core/modules/workspaces_ui/css/workspaces.overview.pcss.css
Remaining tasks
Postponing on sibling issues, as that will make this easier.
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3621198
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
quietone commentedComment #4
smustgrave commentedThis one had a lot and no sure what tests have been addressed in other tickets. Example /RequirementsPageTrait.php
Comment #5
quietone commentedAdded a grep command to the issue summary.
The example in the above, RequirementsPageTrait.php, is excluded because it is in a test path, /core/tests/Drupal/Tests.
Comment #6
quietone commentedSetting to Active because I want to make another look at this.
Comment #7
quietone commentedComment #8
quietone commentedComment #9
quietone commentedI found a test that didn't get updated.