Problem/Motivation

There is a new grant permissions method, we should update UserCreationTrait::grantPermissions() to use that.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3621087

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

amateescu’s picture

amateescu commented
Title: [pp-1] update UserCreationTrait::grantPermissions() to use new RoleInterface::grantPermission. » Update UserCreationTrait::grantPermissions() to use new RoleInterface::grantPermissions
Issue summary: View changes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Maybe we should deprecate that directly instead of updating it, it's a one-liner then and the caller still has to load the role correctly, we can't fix the loadOverrideFree problem within this method, this doesn't really make it shorter anymore. Would be slightly different if we'd pass an ID, but we don't.

danielveza made their first commit to this issue’s fork.

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented

Yeah I agree with @berdir on this one. The only arguement I could see against it would be that it's used a bit in contrib, but the replacement is pretty easy to implement.

I'll work on this one today/tomorrow.

danielveza opened merge request !17051

danielveza’s picture

danielveza
he/him
Location Brisbane, AU
commented
Status: Active » Needs review

Had a crack at this, will need a CR and the node ID changed in the PR. Just wanted to get approval on the deprecation before bothering.

smustgrave’s picture

smustgrave commented

Is this something we really want to do? What's the pro?

May just be me but think UX of just calling " $this->grantPermissions(Role::load(Role::AUTHENTICATED_ID), ['use editorial transition publish'])" is cleaner/easier then the alternative.