The reset for the Navigation module toolbar was removed in #3565213: Adjust contextual CSS for navigation module reset CSS.

This re-creates all the issues found in #3511280: Front-end theme styles can bleed into Navigation

Issue fork drupal-3619897

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mherchel created an issue. See original summary.

godotislate’s picture

godotislate
he/him
commented
Issue tags: +Needs frontend framework manager review

Needs input from FEFMs on how to proceed.

@mherchel said "My thought is we should 1) revert the commit, and 2) Refactor the contextual links CSS to support it (it would be a minor lift)" on Slack.

Alternative suggestions include using shadow DOM.

Edit: I've unpublished the CR https://www.drupal.org/node/3560492 for now.

godotislate’s picture

godotislate
he/him
commented

@nod_ agreed on slack that the reset should be restored with a different way to solve the issue with contextual links.

godotislate’s picture

godotislate
he/him
commented

I've republished the CR https://www.drupal.org/node/3560492 and created a new CR https://www.drupal.org/node/3622520 documenting that the reset was weakened or undone.