Problem/Motivation
I found some flaws in and related to `Drupal\Core\Hook\OrderOperation\OrderOperation`:
- In ModuleHandler, a property with packed order operations has `@param` instead of `@var`.
- The doc type of that property is wrong.
- A missing space after "match".
- In OrderOperation::unpack() we can avoid a string variable containing a class name.
- We can improve doc types for phpstan.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3618622
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
charlliequadros commentedHi @donquixote
I’ve made the changes.
Could you please check if everything looks correct?
If you need anything, please let me know.
Comment #5
charlliequadros commentedComment #6
donquixote commentedHello @charlliequadros,
I already had the commits for this in my local env, but did not take the time to push it.
My code is almost identical except for one point, going to comment.