Problem/Motivation

Performance test pipelines run component unit tests, but they shouldn't.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3617503

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !16735

catch’s picture

catch
he/him
Primary language English
commented

Isn't testable on an MR pipeline, Here's an example of one with the extra job running that we don't want: https://git.drupalcode.org/project/drupal/-/pipelines/926127

dcam’s picture

dcam commented
Status: Needs review » Needs work
Related issues: +#3521541: [CI] Components tests coverage metrics differ by PHP version

@catch I may be showing my ignorance, but I'm confused by this.

These lines were added when #3521541: [CI] Components tests coverage metrics differ by PHP version was reopened by @alexpott who said:

We broke this in #3515704 as component tests are again excluded from the performance tests.

And the following comment was added to .gitlabci at that time:

  # Jobs that produce metrics must run on performance test pipelines so MRs show
  # the correct information.

Both of these seem to be at odds with the assertion "Performance test pipelines run component unit tests, but they shouldn't."

Further confusing the issue is that the other issue added $PERFORMANCE_TEST != "1". Isn't this condition the opposite of what was supposed to be added?

If we're reversing that decision, then OK, but it seems like we should delete that comment from .gitlabci and the fact that it's being overturned should be documented in this issue summary the next time someone comes looking for an explanation.