Problem/Motivation

Now that OpenTelemetryPerformanceTest is a collection of protected methods called in sequence, some cache warming steps are redundant. This should save a few seconds off each run of the test.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3616193

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !16663

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Test failures appear related to random ckeditor5 from the chromedriver update. This LGTM.

amateescu’s picture

amateescu commented

Does this need to be rebased after #3618432: [Needs docs updates] Performance tests: Move expected metrics and queries to files, for better diffs and automated updates?

berdir made their first commit to this issue’s fork.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I don't think so, this only touches things that don't conflict, I did a rebase to be sure, but that issue shouldn't have changed anything about what we test, just how we assert the the results, this is thee opposite, this only changes the setup.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 9a2af7678f6 to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed 9a2af767 on main 
    test: #3616193 Rationalise cache warming in OpenTelemetryPerformanceTest...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.