Postponed
Project:
Drupal core
Version:
main
Component:
system.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Aug 2026 at 23:31 UTC
Updated:
7 Aug 2026 at 15:42 UTC
Jump to comment: Most recent
In #3585079: Convert remaining system module routes to use attributes I mentioned we could move some routes and controllers out of system module now that they can be discovered by attributes. For example, EntityAutocompleteController could move to the Drupal\Core\Entity\Controller namespace.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
mstrelan commentedFrom @godotislate in the other issue:
Comment #3
mstrelan commentedI think this only works for
EntityAutocompleteControllerandTimezoneController. For the others we need to add 'Controller' and 'Form' in\Drupal\Core\DrupalKernel::compileContainer, as below:That would allow the following, and possibly others:
BatchControllerCronControllerCsrfTokenControllerHttp4xxControllerComment #4
mstrelan commentedWe probably want to deprecate the old route names too,
system.entity_autocompletewon't make sense once it's out of system module. Maybecore.entity_autocompletewould be a good replacement. Apparently we can use\Symfony\Component\Routing\Attribute\DeprecatedAliasin Route attributes to do this.Comment #6
mstrelan commentedPostponed on #3585079: Convert remaining system module routes to use attributes
Comment #8
godotislateYes, changing the route names and adding aliases to the old names makes sense to me.
I addressed the PHPStan issue, basically a return statement was missing outside the if conditions, but since nothing should presumably get there, threw an access denied exception.
One FJ test has failed multiple times, and since this MR still needs work anyway, not going to try running it again for now.