Problem/Motivation

In 11.4, we added a new optional argument to RouteProvider.

What's special about that is that it has already two optional arguments, the table name, which is only used in kernel tests, and the language manager, which is optional but shouldn't be but was never officially deprecated.

Steps to reproduce

Proposed resolution

Remaining tasks

Do we only deal with the explicitly deprecated argument, or do we something more? I guess it's tricky as those things aren't deprecated.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3614493

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

berdir created an issue. See original summary.

berdir opened merge request !16517

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

I didn't make LanguageManager required, but I did switch it all to promoted properties.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Unrelated javascript failures.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs followup

I think we should open an issue to see if we can remove the $table_name argument via refactoring the tests and also to make the language manager required.

MR looks good in itself.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs followup

Opened #3614851: Potentially deprecate $table_name from RouteProvider

  • catch committed ff4a9e08 on main 
    task: #3614493 Remove BC from RouteProvider::__construct()

By: berdir
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.