PHPUnit 13.2 deprecates TestCase::expectExceptionMessage() in favor of TestCase::expectExceptionMessageIs() (stricter) or TestCase::expectExceptionMessageIsOrContains() (equivalent to TestCase::expectExceptionMessage()).
See Improved API for exception message expectations
Focus on tests from the unit-component test suite and for tests extending directly from TestCase in this issue.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #5
mondrakeComment #6
dcam commentedI found one issue with a failing test. Please review my comment on the MR.
Otherwise the changes look good. All uses of
expectExceptionMessage()are replaced in the Component tests.Comment #7
mondrakeComment #8
mondrakeComment #9
dcam commentedOh. Of course. Yes, I was testing on 13.2.5. 🙄
I reran the tests on 13.2.5. There were no failures this time. I think this is good to go.
Comment #10
catchNot sure about using the trait in the test classes.
The idea behind the components is that they add implicit dependencies (or any dependencies) on code from other namespaces, but the test trait does this. Do we need to add drupal/core to require-dev or something?
Comment #11
mondrake#10 sounds like another reason to do #3614056: Define Drupal\TestTools namespace in root composer.json or something similar?
Comment #12
mondrakeThe trait would be temporary until we bump to PHPUnit 13, though. We will have to remove it at that time, since the new methods in PHPUnit 13 are final and we would get fatals if we don’t.
Comment #13
mondrake