Problem/Motivation

The committed notification says that there is no replacement. The replacement is \Drupal\Core\Htmx\HtmxRequestInfoTrait::getHtmxSource

Steps to reproduce

Examine the notifications

Proposed resolution

Correct the text

Remaining tasks

Review and commit

User interface changes

None

Introduced terminology

None

API changes

None

Data model changes

None

Release notes snippet

Issue fork drupal-3611853

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fathershawn created an issue. See original summary.

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Status: Active » Needs review

fathershawn opened merge request !16359

nicxvan’s picture

nicxvan commented
Status: Needs review » Needs work

I think we need to update the original CR too, I don't see a mention of this change there either, not sure how I missed that.

https://www.drupal.org/node/3583674

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented

We clearly are on the “same wavelength!” I must have been updating as you were commenting! https://www.drupal.org/node/3583674#htmx-4-headers

nicxvan’s picture

nicxvan commented
Status: Needs work » Reviewed & tested by the community

Looks good!
Failure is nightwatch which I can't rerun.

I'm going to publish the CR too.

Edit: maybe it's not ready to publish yet.

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented

Thanks for the RTBC! Yeah @longwave said to wait on the CR until the main issue is committed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 4163754634a to 11.x. Thanks!

The deprecations aren't in main, so this only needs to land there.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !16359

  • longwave committed 41637546 on 11.x 
    fix: #3611853 Correct error deprecation message for \Drupal\Core\Htmx\...