Problem/Motivation

Original issue: #3516034: Add cacheable metadata to SelectInterface and entity QueryInterface objects

We deprecated not consuming cacheable metadata from queries, but in order to make the original issue go green we temporarily discarded the metadata in \Drupal\Core\Entity\Plugin\EntityReferenceSelection\DefaultSelection and \Drupal\comment\Plugin\EntityReferenceSelection\CommentSelection.

This is the same as the old behavior, so nothing has changed so far, but we want to make sure we properly handle whatever cacheability comes in from the query, or properly investigate and document why we're fine with discarding it.

Steps to reproduce

N/A

Proposed resolution

N/A

Remaining tasks

  1. Review the 3 @todo items pointing to this issue in DefaultSelection
  2. Review the 1 @todo item pointing to this issue in CommentSelection

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

Title: [PP-1] Review discarding of query cacheable metadata in DefaultSelection » [PP-1] Review discarding of query cacheable metadata in DefaultSelection and CommentSelection
Issue summary: View changes