Problem/Motivation

The BC layer in locale_translation_get_projects() is implemented incorrectly - an empty array should return all projects.

Steps to reproduce

Call locale_translation_get_projects() on 11.3.x and on 11.4.x and see the difference.

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3609020

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

nicxvan made their first commit to this issue’s fork.

nicxvan opened merge request !16242

nicxvan’s picture

nicxvan commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Needs work

Yep this is exactly what we need to do. Imo because we have logic we should have a test.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review

I've added tests

nicxvan’s picture

nicxvan commented
Status: Needs review » Reviewed & tested by the community

Test looks good, I can't run test only changes against core committer pipelines so I manually pulled this in and ran the test with and without the changes and confirmed it fails when the fix is missing.

I think I'm ok to mark it here since 5 was a review of my code and I'm reviewing just the tests.

  • catch committed aec68060 on 11.4.x 
    fix: #3609020 BC layer in locale_translation_get_projects() implemented...

  • catch committed fd461027 on 11.x 
    fix: #3609020 BC layer in locale_translation_get_projects() implemented...

  • catch committed a009581e on main 
    fix: #3609020 BC layer in locale_translation_get_projects() implemented...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, 11.x and 11.4.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !16242

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.