Fixed
Project:
Drupal core
Version:
11.x-dev
Component:
database system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Jul 2026 at 10:50 UTC
Updated:
22 Jul 2026 at 14:46 UTC
Jump to comment: Most recent
Spin off from #3399150: [PP-2] Enable dynamic queries to produce SQL with positional placeholders.
Problem/Motivation
\Drupal\Core\Database\Query\Insert::execute() is overriden in all core implementations, and therefore the base implementation is missing test coverage.
Proposed resolution
Convert \Drupal\Core\Database\Query\Insert to abstract class and make its ::execute() method abstract too.
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3608493
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
mondrakeComment #4
mondrakeComment #5
daffie commentedAll code changes look good to me.
The change is right.
The sqlsrv database driver has its own implementation of Insert::Execute().
I do not see BC breaking.
For me it is RTBC.
Comment #6
catchThis looks fine but I think we need a change record.
Also, should there be an 11.x version of this where the method triggers a deprecation error?
Comment #8
mondrakeAdded a 11.x MR that only triggers a deprecation in case the methods are called, and a draft CR.
Comment #9
daffie commentedBoth remarks of @catch have been addressed.
Back to RTBC.
Comment #14
catchCommitted/pushed to main and the respective MR to 11.x, thanks!