Problem/Motivation

Drupal 11.4.0 removed recipes from core, because they were no longer needed by the Standard profile and recipe. However, they were in the dependency chain for other recipes / site templates that opted to build on these "standard" content types vs. define them from scratch. (In our case, the goal was to remain interoperable with other recipes that enhanced the standard page and article content types.)

Their absence now generates fatal errors when our recipes try to apply.

Steps to reproduce

composer create-project centarro/commerce-kickstart-project kickstart
cd kickstart
ddev config
ddev start

And attempt the full demo store installation.

Proposed resolution

Restore these recipes to the codebase even if they are no longer applied and provide a deprecation notice so recipe and site template developers know to accommodate their absence at the next major version bump (i.e., Drupal 12.0.0).

Remaining tasks

Give it a shot!

Release notes snippet

TBD

Issue fork drupal-3608069

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rszrama created an issue. See original summary.

rszrama’s picture

rszrama commented
Issue summary: View changes

rszrama opened merge request !16195

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

+1 for this. Removing these recipes in a minor release is equivalent to pulling a module out of core in a minor release, although obviously it cannot break sites in the wild.

I think these recipes should remain in 11.x, but remain removed from 12.x.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I agree this had farther reaching consequences than we thought. Should we have / do we have a way to mark the recipes deprecated?

catch’s picture

catch
he/him
Primary language English
commented

I think it's worth an issue to look into marking recipes deprecated, however I also think until we have that, restoring them to 11.x but keeping them removed in 12.x is OK with the existing change record.

catch’s picture

catch
he/him
Primary language English
commented
Category: Feature request » Task
Status: Active » Reviewed & tested by the community

Let's go ahead here, MR is green and is just a partial revert of a commit.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Added these back to 11.x and 11.4.x, let's keep them out of 12, if we figure a way to deprecate recipes in the meantime we can backport that later.

Committed and pushed bae80c73c61 to 11.x and 7885da50fcb to 11.4.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !16195

  • longwave committed 7885da50 on 11.4.x 
    fix: #3608069 Restore (but don't apply) deprecated recipes to 11.4.x

By...

  • longwave committed bae80c73 on 11.x 
    fix: #3608069 Restore (but don't apply) deprecated recipes to 11.4.x

By...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Thanks! 🙏 This will allow Canvas to no longer have to add ~300 lines of YAML for it to pass tests on 11.4! 🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.