Problem/Motivation

Currently in ConfigSingleExportForm to select and replace the field including its wrapper, we are using the CSS "has" selector: select('*:has(>select[name="config_name"])'). This works but is complex.

Proposed resolution

Add a data-drupal-wrapper-selector attribute to the wrapper element so that it can be directly targeted easily.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3603310

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fathershawn created an issue. See original summary.

fathershawn opened merge request !16093

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Issue summary: View changes
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Status: Active » Needs review

ConfigSingleExportForm working properly using the new selector to replace the config name select element and to return the export text area with the result.

smustgrave’s picture

smustgrave commented

Question could this be a breaking change for someone's custom build? Know it's a task does it need coverage or fact tests pass the coverage?

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented

Since this adds a new data attribute I don't think it would break anything.

The updated usage in ConfigSingleExportForm implicitly tests it. I'm happy to build a direct test if that's desired.

smustgrave’s picture

smustgrave commented

Mind rerunning the failed test job?