Problem/Motivation

In #3587182: Update CKEditor 5 to 48.0.1 CKEditor 5 was updated to v48, which sunsets the old installation method and requires updating to the modern installation method.

Proposed resolution

This is straightforward, we just need to update the import paths.

Remaining tasks

  1. Update the import paths & rebuild
  2. Review
  3. Commit

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3591974

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pameeela created an issue. See original summary.

pameeela opened merge request !15866

pameeela’s picture

pameeela commented
Issue summary: View changes
Status: Active » Needs review
pameeela’s picture

pameeela commented
Related issues: +#3587182: Update CKEditor 5 to 48.0.1
godotislate’s picture

godotislate
he/him
commented

The ckeditor documentation https://ckeditor.com/docs/ckeditor5/latest/updating/nim-migration/migrat... is a little unclear about whether the icons are available in the ckeditor package (probably not because I think they moved icons out of the main package a couple versions ago?).

Separately, I wonder if it's a good idea to delete the CI eslint cache file periodically, in case some upstream changes create JS linting issues like we saw here.

pameeela’s picture

pameeela commented

Agree it wasn't super clear but I tested updating it and everything still works, so worth doing.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Believe I experienced this when I was updating ckeditor5_dev and other ckeditor contrib modules lots of fun (being sarcastic)

Applied the MR and did testing on standard profile trying out all the ckeditor buttons from core, specifically the media embed. All seems to be working as expected. I cleared cache several times too to make sure it took.

Assuming this will be a D12 only?

godotislate’s picture

godotislate
he/him
commented

Assuming this will be a D12 only?

Yes.