Problem/Motivation

Spin-off from #3516173: Block status code visibility condition should use a status code cache context.

We should have a test that visits one 404 page to warm the dynamic page cache, then visits a different 404 page to make sure that the minimum of page-specific queries run.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3589683

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
Issue tags: +gander

catch opened merge request !15742

smustgrave’s picture

smustgrave commented

Don't mind marking for you but mind explaining the config change?

catch’s picture

catch
he/him
Primary language English
commented

@smustgrave I've reverted the config change, that was a failed attempt to try to trigger the difference that #3516173: Block status code visibility condition should use a status code cache context should show, but we won't be able to see that via Umami without at least one additional change on top of this. Opened yet another issue for that one #3589822: Try to reduce cache context granularity from path conditions. The test coverage added here will be useful for that issue.

Because Umami doesn't show what I want it to show for #3516173: Block status code visibility condition should use a status code cache context I additionally added similar coverage to StandardPerformanceTest which hopefully should.

catch’s picture

catch
he/him
Primary language English
commented

Additionally needed to add the response status condition on the breadcrumbs block in Olivero to get this to show up. For me it makes sense to change that directly in Olivero - not sure why you'd want breadcrumbs on 404 pages, but we could also change the set-up of the performance test to do it so this doesn't get blocked on that.

Main thing is to unblock the other issue by having a test that actually demonstrates the problem.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

This is looking good but appears to have a breadcrumb error now

catch’s picture

catch
he/him
Primary language English
commented

Yep that's because it tests with Olivero (which is interesting in itself). Need to see what the verdict is on #3516173-23: Block status code visibility condition should use a status code cache context before doing any more here.