Problem/Motivation

We have ranges on these assertions in performance tests so that small CSS/JS changes don't require updating every time, but we still end up with a lot of updates and commit conflicts, I think we should double the range or so and see how it goes.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3588897

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

catch opened merge request !15693

finnsky’s picture

finnsky commented

This will be the most useful change in Drupal core! :) Thanks!!

catch’s picture

catch
he/him
Primary language English
commented

What I'm hoping with this is that smaller changes won't have to change these number at all, that means nothing to conflict with when bigger changes need to. Bigger changes will still conflict with each other, but that's unfortunately more or less inherent unless we come up with another way.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

yes please :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: main » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed f6103006dd5 to main and 41d0af94cf7 to 11.x and 745ffb73a49 to 11.3.x. Thanks!

Backported to 11.3.x to make backports easier. Test-only be definition.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 745ffb73 on 11.3.x 
    task: #3588897 Widen the script/stylesheet bytes assertion ranges in...

  • alexpott committed 41d0af94 on 11.x 
    task: #3588897 Widen the script/stylesheet bytes assertion ranges in...

  • alexpott committed f6103006 on main 
    task: #3588897 Widen the script/stylesheet bytes assertion ranges in...