SystemAdminThemePreprocess::preprocessSystemModulesDetails() shows @theme instead of the theme name that depends on a module

I could have used the following code, but I decided it was a minimal optimization.

if (isset($form[$dependency])) {
  $args = ['@theme' => $theme->info['name']];
  // Add themes to the module's required by list.
  $form[$dependency]['#required_by'][] = $theme->status ? $this->t('@theme (theme)', $args) : $this->t('@theme (theme) (<span class="admin-disabled">disabled</span>)', $args);
}

It should avoid that '@theme' and '@theme (theme)' are exchanged again, but I do not expect that to happen again.

The test failure (ConfigInstallProfileOverrideTest.php, line 141) does not seem caused by this change.

    // Installing dblog creates the optional configuration.
    $this->container->get('module_installer')->install(['dblog']);
    $this->rebuildContainer();
    // Line 141
    $this->assertEquals('Override', $config_test_storage->load('override_unmet')->label(), 'The optional config_test entity is overridden by the profile optional configuration and is installed when its dependencies are met.');
    $config_test_new = $config_test_storage->load('completely_new');
    $this->assertEquals('Completely new optional configuration', $config_test_new->label(), 'The optional config_test entity is provided by the profile optional configuration and is installed when its dependencies are met.');
    $config_test_new->delete();

This is not an intentional change, and it introduces an error. What would be shown as dependency is not the theme name, but the literal string '@theme' because '@theme' is not one of keys in the array passed as second argument (which in fact is ['@theme (theme)' => $theme->info['name']]).
The code I quoted is for themes that depend on modules. Drupal core themes do not depend on modules, so this bug is not evident for them, but it will appear when a contributed theme depends on a module (which does not probably happen so often).

Knowing in which issue this change has been done could serve to know if the same change has been done in more files, in the same commit. For that, it is sufficient to use git grep --fixed-string, which would retrieve similar typos done in other commits too.

The following code has been added in #474684: Allow themes to declare dependencies on modules.

 // Identify modules that are depended on by themes.
 // Added here instead of ModuleHandler to avoid recursion.
 $themes = \Drupal::service('extension.list.theme')->getList();
 foreach ($themes as $theme) {
   foreach ($theme->info['dependencies'] as $dependency) {
     if (isset($form[$dependency])) {
       // Add themes to the module's required by list.
       $form[$dependency]['#required_by'][] = $theme->status ? t('@theme', ['@theme (theme)' => $theme->info['name']]) : t('@theme (theme) (<span class="admin-disabled">disabled</span>)', ['@theme' => $theme->info['name']]);
     }
   }
 }

None of the comments in that issue says that passing '@theme' as first argument and ['@theme (theme)' => $theme->info['name']] as second argument was intentional. (It should not be intentional, since that would output @theme as literal string, not the theme name.)

I made the title and the issue summary more explicit about what the bug is. I also added in the issue summary what I discovered about the issue that added the quoted code.