Problem/Motivation

Follow up of #3398767: Allow returning explicitly to the prior nesting level in transactions (aka allow explicit COMMIT in Transaction objects) and #3406985: Convert all transactions in core to use explicit ::commitOrRelease().

Proposed resolution

In this issue :

Deprecate the following methods in Drupal\pgsql\Driver\Database\pgsql\Connection:

  • ::addSavepoint()
  • ::releaseSavepoint()
  • ::rollbackSavepoint()

Remaining tasks

User interface changes

No

API changes

No

Data model changes

No

Release notes snippet

Issue fork drupal-3583849

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !15392

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Active
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

This may also fix #2920527: Postgres driver issue with nested savepoints mimic_implicit_commit duplicated.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Needs change record

other then CR it looks good to go, RTBC++

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs change record

It exists already just was not linked, so looks ready

  • amateescu committed 63e91839 on 11.x 
    task: #3583849 Deprecate PgSql Connection::*Savepoint() methods

By:...

  • amateescu committed 5b4ad871 on main 
    task: #3583849 Deprecate PgSql Connection::*Savepoint() methods

By:...
amateescu’s picture

amateescu commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 5b4ad871353 to main and 63e91839f35 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

amateescu closed merge request !15392

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.