Add return types to BasicAuthResourceTestTrait

Lets do it! Pretty simple review

Think it would be nice to get these trait return types in before we bump phpstan btw, just to reduce size.

Needs a rebase after #3575324: Add return type documentation to ResourceTestBase.

Done rebasing from UI.

Seems @longwave may have done the rebase that resolved the conflict if you’re saying the rebase worked through the UI.

One question: The IS says, "Another simple case where we can remove 186 entries from the baseline," but there are no baseline changes here?

I'd expect to see something like this removed:

$ignoreErrors[] = [
	'message' => '#^Method Drupal\\\\Tests\\\\block\\\\Functional\\\\Rest\\\\BlockJsonBasicAuthTest\\:\\:assertAuthenticationEdgeCases\\(\\) has no return type specified\\.$#',
	'identifier' => 'missingType.return',
	'count' => 1,
	'path' => __DIR__ . '/modules/block/tests/src/Functional/Rest/BlockJsonBasicAuthTest.php',
];

It was definitely there at some point, see https://git.drupalcode.org/project/drupal/-/merge_requests/15204/diffs?c..., but I think it was lost in of the rebases..

Wouldn't phpstan be failing now?

Yes, the PHPStan job should fail. It's strange.

Back to NW to look into the PHPStan thing.

Re: #9 to #13, There seem to be 2x MR's authored by @longwave with the same ID but containing different commit ID's?

Looking at this:
https://git.drupalcode.org/project/drupal/-/merge_requests/15204/diffs?c...

It seems that the 1 change which is in fact 186 individual deletions from the phpstan baseline file in commit c3dd89662e88cac08f070df0e487ec14a4701837 resulted from the regeneration of the phpstan baseline file after the 2x commits a7652b7de19013534f601161fe3f87bb032e3e34 and 56105c88131259bace36bbfe142a77ab811479f4 were made in other files.

Normally the 'Changes' tab would reveal the 'changes' made to all 3x files, not just 2x files.

This is confusing to me, but could it be that this is how the Gitlab pipelines are configured (recently?) to handle commits that affect the phpstan baseline? Something like, MR commits add return types, the newly added return types trigger a phpstan baseline regeneration done by the pipeline and the pipeline creates a commit for the new phpstan-baseline.php? So manual deletions from the .phpstan-baseline.php file are no longer necessary? And it is no longer necessary to commit the .phpstan-baseline.php file?

Please pardon the groping around in ignorance, hoping to shed a sliver of light on something.

Rebased again and PHPStan did not fail either. This really is strange.

Re: #14

There seem to be 2x MR's authored by @longwave with the same ID but containing different commit ID's?

I take that back. There is only 1 MR.

Re: #15, Not sure if this helps explain that, but commit c3dd89662e88cac08f070df0e487ec14a4701837 seems to be committed in the MR so the 186 removals from the .phpstan-baseline.php file are in the MR. I opened the Web IDE for the MR and searched for one of the 186 deletions. Not found. So is commit c3dd89662e88cac08f070df0e487ec14a4701837 present but hidden in the MR?

If you go here:

https://git.drupalcode.org/project/drupal/-/merge_requests/15204/diffs?c...

Then click on 'Show latest version' button. You then seem to be in the same MR but with only the 2 commits. You lose commit c3dd89662e88cac08f070df0e487ec14a4701837.

Actually this is expected. The methods extend from ResourceTestBase where they have @return void since #3575324: Add return type documentation to ResourceTestBase

Probably we don't need to proceed with this issue, or we can commit as is.

#19: Ah good catch, didn't realize that those lines in the baseline had already been removed.

Since #3575324: Add return type documentation to ResourceTestBase only went into main, this will only go into main.
Committed 9434496 and pushed to main. Thanks!