Problem/Motivation

Part of #3529510: [meta] Add return types to test traits

Adding return types to two functions in a trait removes 1176 lines from the baseline, resolving 196 violations.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3579915

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !15133

mstrelan’s picture

mstrelan commented
Issue summary: View changes
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems pretty straight forward. Nice chunk out of the baseline too +1

godotislate closed merge request !15133

  • godotislate committed ff1d1e78 on main 
    test: #3579915 Add return types to AnonResourceTestTrait

By: mstrelan...
godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Patch (to be ported)

Committed ff1d1e7 and pushed to main. Thanks!

Need an MR with a regenerated baseline for 11.x

smustgrave’s picture

smustgrave commented

Want to confirm still something we want for 11.x?

smustgrave’s picture

smustgrave commented
Version: main » 11.x-dev
Status: Patch (to be ported) » Reviewed & tested by the community

Gitlab is being SUPER slow but this actually applied cleanly with some fuzziness on the baseline.

smustgrave opened merge request !15674

  • longwave committed 8dc2b3dd on 11.x 
    test: #3579915 Add return types to AnonResourceTestTrait

By: mstrelan...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8dc2b3dd7de to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

longwave closed merge request !15674