Problem/Motivation

PHPUnit 12.5.0+ is changing the way that mock objects work:

  • Mock objects that do not configure expectations should be converted to stubs. Otherwise, they throw a notice: No expectations were configured for the mock object for \Drupal\comment\CommentManagerInterface. You should refactor your test code and use a test stub instead.
  • $this->any() is deprecated. It was equivalent to having no expectation, in which case the object should be a stub (see the previous bullet) or a more exact number of expectations should be added.
  • with() is deprecated for stubs because it was deemed to be equally pointless.

Steps to reproduce

  1. Require PHPUnit 12 with Composer.
  2. Fix compatibility issues with PHPUnit 12 by applying this patch.
  3. Run the Unit tests for a library with --display-phpunit-notices --display-phpunit-deprecations.
  4. Observe the PHPUnit notices that occur.

Proposed resolution

Fix notices in the tests in the Render library's tests.

MetadataBubblingUrlGeneratorTest has been removed from the scope of this issue. See #3.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3579885

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dcam created an issue. See original summary.

dcam opened merge request !15124

dcam’s picture

dcam commented
Status: Active » Needs review

The changes to MetadataBubblingUrlGeneratorTest were moved to the MR in #3579890: Convert expectation-less test mocks to stubs - Database, Routing. That test class is a child of a Routing test and that MR doesn't pass without it.

dcam’s picture

dcam commented
Issue summary: View changes
dcam’s picture

dcam commented

FYI: the recently-committed UnitTestCase changes have been merged into this MR, so they do not need to be applied separately for testing.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

I do get this error TypeError: Drupal\Tests\Core\Render\RendererPlaceholdersTest::setupThemeManagerForDetails(): Return value must be of type PHPUnit\Framework\MockObject\Builder\InvocationMocker, PHPUnit\Framework\MockObject\InvocationStubberImplementation returned

Marking that test skipped I get Tests: 366, Assertions: 1358, Skipped: 1. So all deprecations appear addressed and seems inline with everything that's been committed thus far.

dcam’s picture

dcam commented

The last rebase was a bit rough on the baseline, so I had to download the artifact from GitLab. The copied artifact had the wrong file permissions. So I fixed them. Leaving this at RTBC.

catch closed merge request !15124

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to main, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed fd919989 on main 
    task: #3579885 Convert expectation-less test mocks to stubs - Render...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.