Problem/Motivation

The following tests install Shortcut

  • core/tests/Drupal/FunctionalJavascriptTests/Theme/ClaroBlockFilterTest.php
  • core/tests/Drupal/FunctionalJavascriptTests/Theme/ClaroEntityDisplayTest.php
  • core/tests/Drupal/FunctionalTests/Theme/ClaroTest.php
  • core/themes/admin/tests/src/Functional/AdminTest.php

And they have a comment like this

   * Install the shortcut module so that claro.settings has its schema checked.
   * There's currently no way for Claro to provide a default and have valid
   * configuration as themes cannot react to a module install.

The comment was added in #3079738: Add Claro administration theme to core

Steps to reproduce

Proposed resolution

Remove use a shortcut. See comment #2.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3579267

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Issue summary: View changes

I asked about that comment in #core-development. catch did initially thought that for the default admin theme that remove shortcut is removed from the tests then open an issue opened in default_admin issue to either fix the tests or remove the comment since it's still experimental. And later, when I linked to the original commit, which was in 2019, he that it was just cruft that we have been carrying around. It is possible that it wasn't valid at the time Claro was committed to core.

So, this will remove the use of shortcut in these tests.

quietone opened merge request !15219

quietone’s picture

quietone commented
Status: Active » Needs review
catch’s picture

catch
he/him
Primary language English
commented

Yes I think we can drop this, I checked the settings for both claro and default_admin and there's no reference to shortcut module in either, best guess is there was in the very early stages of Claro development and the test workaround never got removed when the config did.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Should have marked this RTBC too :)

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8fb7e5a7a74 to main and d5e45f6c77a to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed d5e45f6c on 11.x 
    test: #3579267 Change use of Shortcut in theme tests

By: quietone
By:...

longwave closed merge request !15219

  • longwave committed 8fb7e5a7 on main 
    test: #3579267 Change use of Shortcut in theme tests

By: quietone
By:...