Problem/Motivation

In #3567618: Create service for image_path_flush, image_style_options and constant for IMAGE_DERIVATIVE_TOKEN I noticed a bunch of formatters directly inject the storage or set it in the constructor.

This can result in a stale reference to the storage object.

Also remove the create method where possible.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3575042

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

nicxvan commented
Issue summary: View changes
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Related issues: +#3162827: Do not instantiate entity storages in constructors of services that do not always need them

See also #3162827: Do not instantiate entity storages in constructors of services that do not always need them

amateescu’s picture

amateescu commented
Title: [pp-1] Fix antipattern of injecting image_style storage directly » Fix antipattern of injecting image_style storage directly
Status: Postponed » Active

Blocker is in.

phenaproxima made their first commit to this issue’s fork.