Problem/Motivation

All of the functions in the file are deprecated, let's deprecate the actual file.

Steps to reproduce

Open file.

Proposed resolution

Deprecate it

Remaining tasks

Review
Confirm decisions in 2.

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3560397

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan opened merge request !13978

nicxvan’s picture

nicxvan commented
Issue summary: View changes
Status: Active » Needs review

I deprecated the file itself, I used the same CR the last function used since that is when the deprecation likely should have happened.

If this warrants it's own CR let me know and I'll update it.

Not sure if this can get in for 11.3.0. I don't think it's urgent either way.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

since the function is already deprecate in 11.3 we might want to do 11.3 too, not exactly sure what the purpose is of deprecating in 11.4 for D12. but it's useful to flag this off explicitly, since if it's being called, then likely together with a loadInclude(), and this will tell people to skip that loadInclude() as well.

longwave made their first commit to this issue’s fork.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Let's just ship this in 11.3.

nicxvan’s picture

nicxvan commented

It's green and changes look right!

  • longwave committed c3c197dc on 11.3.x 
    task: #3560397 Deprecate node.admin.inc

By: nicxvan
By: berdir
By:...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed b8f7910bd5b to 11.x and c3c197dc5f5 to 11.3.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed b8f7910b on 11.x 
    task: #3560397 Deprecate node.admin.inc

By: nicxvan
By: berdir
By:...

longwave closed merge request !13978

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented

https://www.drupal.org/project/drupal/issues/3533315 returns a 404.

nicxvan’s picture

nicxvan commented

Whoops, that's an issue link: it should be: https://www.drupal.org/node/3533315

I copied the deprecation message from somewhere so I need to find that too.

nicxvan’s picture

nicxvan commented

Created: #3560560: Fix deprecated messages that reference issue instead of change record since there are more instances.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Oops, thank you for finding this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.