Problem/Motivation

Navigation module implements several TrustedCallback methods. Most of them are implemented defining the TrustedCallback attribute.

However, there is a remaining implementation of the old pattern, based on the TrustedCallbackInterface implementation. It is defined in Drupal\navigation\ShortcutLazyBuilder.

For consistency, would be great to modify this class to follow the new pattern.

Steps to reproduce

N/A

Proposed resolution

Follow the steps described in https://www.drupal.org/node/3349470 to convert the callback.

Remaining tasks

Implement TrustedCallback atttribute in Drupal\navigation\ShortcutLazyBuilder.

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3559573

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

aryan singh’s picture

aryan singh commented

Working...

aryan singh opened merge request !13941

aryan singh’s picture

aryan singh commented
Status: Active » Needs review
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

Code looks good, tests are green, and tested locally with no issues.

I think this one can be marked as RTBC.

catch made their first commit to this issue’s fork.

catch closed merge request !13941

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 31d5ad24 on 11.3.x 
    task: #3559573 Replace TrustedCallbackInterface with TrustedCallback...

  • catch committed dd80d899 on 11.x 
    task: #3559573 Replace TrustedCallbackInterface with TrustedCallback...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.