Problem/Motivation

We should be able to test lint caches better....

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3558749

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !13872

longwave made their first commit to this issue’s fork.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

This is great work... can't rtbc but would!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Well actually @longwave completely rewrote my first effort so... I think I can. I can see us using the caches built by the MR when we have labelled the MR - so this is fantastic. It also simplifies some of my prior work on ensuring all of the caching stuff works. Brilliant.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Actually... with the removal of -v on curl we no longer see how big the downloaded file is. It would be useful to know that ... and if it got downloaded....

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Reviewed & tested by the community

Thanks @longwave you've resolved my comments. Nice.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Rebased.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: [CI] Test lint caches better » [CI] Refactor lint cache downloads and allow easier testing
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Really nice clean-up. Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed df254535 on 11.3.x 
    task: #3558749 [CI] Refactor lint cache downloads and allow easier...

  • catch committed 801b9280 on 11.x 
    task: #3558749 [CI] Refactor lint cache downloads and allow easier...

catch closed merge request !13872

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Fixed » Needs review

I missed the last three commits to the original branch from the rebase because I didn't have them locally, fixes some minor bugs that @alexpott and I spotted - new MR opened for that.

longwave opened merge request !13915

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

The follow-up MR looks great.

catch closed merge request !13915

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed the follow-up to both branches, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed bd013c9c on 11.3.x 
    fix: #3558749 [CI] Refactor lint cache downloads and allow easier...

  • catch committed f0f5e442 on 11.x 
    fix: #3558749 [CI] Refactor lint cache downloads and allow easier...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.